-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme no docker & allow using platform default version #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM. Especially I like the example about CLI args compared to action input options.
I just don’t know whether the code change will break something because we don't have a full regression test.
Maybe I can move the test-cpp-linter-action to this org and add some test cases for testing in short term.
Maybe we could add some unit tests for Python code in the long term.
I thought you'd eventually transfer the test repo over also. I'd like to merge the cpp-linter/test-cpp-linter-action#10. The updated workflows will be a good base for testing with and without the docker image. I also agree that the code changes should be tested. The idea to change the |
I tested the version default in this CI run. It worked like a charm (and 15 seconds faster). The changes to Other than those changes, the README update is the only thing left to review. |
version
input option to be blank.version
default is10
.version
is a blank string (allowing the platform's default installed version to be invoked).