Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert changes in logic #68

Merged
merged 1 commit into from
Jun 22, 2022
Merged

revert changes in logic #68

merged 1 commit into from
Jun 22, 2022

Conversation

2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Jun 21, 2022

This is meant to fix the logic revision in #66 . This should fix #67, but I need to test this though.

@shenxianpeng shenxianpeng added the bug Something isn't working label Jun 22, 2022
@2bndy5 2bndy5 marked this pull request as ready for review June 22, 2022 03:34
@2bndy5
Copy link
Collaborator Author

2bndy5 commented Jun 22, 2022

This does indeed fix #67 🎉

Heads up, pip has trouble installing from a branch that has a # in it. I think the workflow actually treated everything after the # in this branch's name like a YAML comment. I had to test this from a duplicate/renamed branch.

@shenxianpeng
Copy link
Collaborator

OK, sure 😀

@2bndy5 2bndy5 merged commit f87ef79 into master Jun 22, 2022
@2bndy5 2bndy5 deleted the fix-#67-regression branch June 22, 2022 05:21
@2bndy5 2bndy5 mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenxianpeng shenxianpeng shenxianpeng approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run linter as Python package FileNotFoundError
2 participants
@2bndy5 @shenxianpeng