Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Python versions in GitHub Actions consistent #80

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

rominf
Copy link
Contributor

@rominf rominf commented Jul 10, 2024

To ensure consistently, use the following Python versions everywhere in CI:

  • 3.8
  • 3.9
  • 3.10
  • 3.11
  • 3.12
  • 3.13
  • pypy3.9
  • pypy3.10

The wheels for Python 3.13 are beneficial for dependent packages such as jsonschema.

Note that PyPy3.8 was dropped since the PyPy website (https://www.pypy.org/) states they currently support Python versions 3.10, 3.9, and 2.7.

To build the extension for PyPy on Windows, "generate-import-lib" in Cargo.toml is needed, as per this GitHub issue:
PyO3/maturin-action#267 (comment)

To ensure consistently, use the following Python versions everywhere in
CI:
- 3.8
- 3.9
- 3.10
- 3.11
- 3.12
- 3.13
- pypy3.9
- pypy3.10

The wheels for Python 3.13 are beneficial for dependent packages such as
`jsonschema`.

Note that PyPy3.8 was dropped since the PyPy website
(https://www.pypy.org/) states they currently support Python versions
3.10, 3.9, and 2.7.

To build the extension for PyPy on Windows, "generate-import-lib" in
`Cargo.toml` is needed, as per this GitHub issue:
PyO3/maturin-action#267 (comment)
@Julian
Copy link
Member

Julian commented Jul 24, 2024

Apologies, I missed some notifications. This looks perfect, thanks!

@Julian Julian merged commit f903627 into crate-py:main Jul 24, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants