-
-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare support for 3.13 #1282
Declare support for 3.13 #1282
Conversation
noxfile.py
Outdated
@@ -35,7 +35,7 @@ | |||
"The Unlicense (Unlicense)", | |||
] | |||
|
|||
SUPPORTED = ["3.8", "3.9", "3.10", "pypy3.10", "3.11", "3.12"] | |||
SUPPORTED = ["3.8", "3.9", "3.10", "pypy3.10", "3.11", "3.12", "3.13"] | |||
LATEST = SUPPORTED[-1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.13 is still not released, so we should "leave this" pointing to "3.12" (by hardcoding it instead of doing [-1]
I guess).
That also presumably explains the CI failure(s), some things don't support 3.13 wheels yet.
Otherwise this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The line is now fixed as suggested. I noticed rpds-py
had no wheels because of this line: https://github.com/crate-py/rpds/blob/0b6ea677974fdf2856d975e9386e16bec441424f/.github/workflows/CI.yml#L164. I will open the PR for building the wheels in https://github.com/crate-py/rpds/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the PR for building wheels for Python 3.13: crate-py/rpds#80.
Fixes: python-jsonschema#1264. Hardcode the `LATEST_STABLE` variable in `noxfile.py` to equal the latest stable Python release.
Perfect, thanks again! |
Fixes: #1264.
📚 Documentation preview 📚: https://python-jsonschema--1282.org.readthedocs.build/en/1282/