Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdf_dict, array, stream has/get/get_mut #177

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Conversation

burrbull
Copy link
Collaborator

@burrbull burrbull commented Oct 29, 2019

split
pdf_lookup_dict() on .as_dict().has(), .as_dict().get() and .as_dict().get_mut()
pdf_get_array on .as_array().get() and .as_array().get_mut()
stream_dict on .as_stream().get_dict() and .as_stream().get_dict_mut()

use output_xref: Vec<xref_entry>

@crlf0710
Copy link
Owner

While this seems good, why don't you just change these into methods...

@cormacrelf
Copy link
Collaborator

@crlf0710 they are methods on pdf_obj in #176, but practically nowhere in the code is there a rust reference, only raw mut pointers, so they are difficult to call at the moment.

@burrbull
Copy link
Collaborator Author

Ok. I'll try.

@crlf0710
Copy link
Owner

Seems good, merging~

@crlf0710 crlf0710 merged commit 511ab5d into crlf0710:oxidize Oct 31, 2019
@burrbull burrbull deleted the assert branch November 18, 2019 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants