remove dead code & replace remaining parse_ident #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me, but since there's quite a few pointer operation stuff, it'll be best to have more eyes on this. |
cormacrelf
reviewed
Oct 31, 2019
| k += 1 | ||
| let q = p.parse_c_ident(); | ||
| if q.is_none() { | ||
| return Err(()); |
| @@ -737,76 +720,60 @@ unsafe fn spc_handler_html_default(mut spe: *mut spc_env, mut ap: *mut spc_arg) | |||
| error | |||
| } | |||
| /* translate wsp* '(' wsp* number (comma-wsp number)? wsp* ')' */ | |||
There was a problem hiding this comment.
Another piece of code where nom might make things a lot cleaner. The parse traits would be usable, with some small wrappers that clone the slice pointer, mutate it, subtract the length from the input and return the remainder and output as a nom::IResult by converting to a basic nom error. Then functions like these would be a few lines long, using nom combinators (except the end bit that mutates, just return the data and use it to mutate elsewhere).
|
Need a rebase, i think... |
|
Done. |
|
Merging~ Thanks~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last commit from #177