Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WSLPath #854

Closed
3 of 11 tasks
Alexhuszagh opened this issue Jun 24, 2022 · 1 comment · Fixed by #856
Closed
3 of 11 tasks

Remove WSLPath #854

Alexhuszagh opened this issue Jun 24, 2022 · 1 comment · Fixed by #856
Assignees
@Alexhuszagh
Labels
A-wsl2-host Area: WSL2 hosts bug

Comments

@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented Jun 24, 2022 •
edited
Loading

Checklist

Describe your issue

Currently, we use wsl -e wslpath -a ... to find the WSL2 path of a file for our mount point on Windows. This poses a few issues:

  • It requires external commands, which add significant overhead.
  • It does not work for UNC paths.

A simple test is as follows:

wsl -e wslpath -a "\\server\share"
wslpath: \\server\share

What target(s) are you cross-compiling for?

No response

Which operating system is the host (e.g computer cross is on) running?

  • macOS
  • Windows
  • Linux / BSD
  • other OS (specify in description)

What architecture is the host?

  • x86_64 / AMD64
  • arm32
  • arm64 (including Mac M1)

What container engine is cross using?

  • docker
  • podman
  • other container engine (specify in description)

cross version

latest main build

Example

No response

Additional information / notes

No response
@Alexhuszagh Alexhuszagh self-assigned this Jun 24, 2022
@Emilgardis
Copy link
Member

for context, wslpath was added in #665

Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 24, 2022
@Alexhuszagh
Remove WSLpath and implement WSL-style path.
74420df 
Removes the dependency on WSL2, and properly handles DOS-style paths,
UNC paths, including those on localhost, even if Docker itself does not
support them.

Closes cross-rs#854.
Related to cross-rs#665.
@Alexhuszagh Alexhuszagh mentioned this issue Jun 24, 2022
Merged
Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 24, 2022
@Alexhuszagh
Remove WSLpath and implement WSL-style path.
276828b 
Removes the dependency on WSL2, and properly handles DOS-style paths,
UNC paths, including those on localhost, even if Docker itself does not
support them.

Closes cross-rs#854.
Related to cross-rs#665.
bors bot added a commit that referenced this issue Jun 24, 2022
@bors @Alexhuszagh
Merge #856
fb5003a 
856: Remove WSLpath and implement WSL-style path. r=Emilgardis a=Alexhuszagh

Removes the dependency on WSL2, and properly handles DOS-style paths, UNC paths, including those on localhost, even if Docker itself does not support them.

Closes #854.
Related to #665.
Supersedes #852.

Co-authored-by: Alex Huszagh <[email protected]>
@bors bors bot closed this as completed in dd64cb0 Jun 24, 2022
@Alexhuszagh Alexhuszagh added the A-wsl2-host Area: WSL2 hosts label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alexhuszagh Alexhuszagh

Labels
A-wsl2-host Area: WSL2 hosts bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove WSLpath and implement WSL-style path. Alexhuszagh/cross
2 participants
@Emilgardis @Alexhuszagh