Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WSLpath and implement WSL-style path. #856

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

Alexhuszagh
Copy link
Contributor

@Alexhuszagh Alexhuszagh commented Jun 24, 2022

Removes the dependency on WSL2, and properly handles DOS-style paths, UNC paths, including those on localhost, even if Docker itself does not support them.

Closes #854.
Related to #665.
Supersedes #852.

Removes the dependency on WSL2, and properly handles DOS-style paths,
UNC paths, including those on localhost, even if Docker itself does not
support them.

Closes cross-rs#854.
Related to cross-rs#665.
Supersedes cross-rs#852.
@Alexhuszagh
Copy link
Contributor Author

Forgot C: won't necessarily map to the current directory if you're not on the same drive, and we have no way of telling which drive we're on in CI.

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

bors r+

src/docker/shared.rs Show resolved Hide resolved
src/file.rs Show resolved Hide resolved
@bors
Copy link
Contributor

bors bot commented Jun 24, 2022

Build succeeded:

@bors bors bot merged commit fb5003a into cross-rs:main Jun 24, 2022
@Alexhuszagh Alexhuszagh deleted the wslpath branch June 24, 2022 22:57
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove WSLPath
2 participants