-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure: add virtual machine data disk attachment resource #584
azure: add virtual machine data disk attachment resource #584
Conversation
/test-examples="examples/compute/virtualmachinedatadiskattachment.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @prfj, I left a comment for you.
Could you please do the manual tests of the resource and fill in the description section?
@turkenf Can you run a new uptest now ? I've added selectors/references and fixed the example file
I've tested using the "Manual Test" method what kind of evidence you want me to put on description ? |
@prfj, just put the output of |
/test-examples="examples/compute/virtualmachinedatadiskattachment.yaml" |
@turkenf applied sugestions please check |
/test-examples="examples/compute/virtualmachinedatadiskattachment.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your effort @prfj, LGTM.
Description of your changes
Fixes #467
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Tested locally by applying CRDs, creating a default ProviderConfig, run
make run
and apply the examples/linuxvirtualmachinedatadiskattachment.yaml fileTested with Uptest