Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: add virtual machine data disk attachment resource #584

Merged
merged 5 commits into from
Nov 13, 2023
Merged

azure: add virtual machine data disk attachment resource #584

merged 5 commits into from
Nov 13, 2023

Conversation

prfj
Copy link
Contributor

@prfj prfj commented Nov 8, 2023

Description of your changes

Fixes #467

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested locally by applying CRDs, creating a default ProviderConfig, run make run and apply the examples/linuxvirtualmachinedatadiskattachment.yaml file

$ kubectl get managed

NAME                                     READY   SYNCED   EXTERNAL-NAME   AGE
resourcegroup.azure.upbound.io/example   True    True     example         7m22s

NAME                                                   READY   SYNCED   EXTERNAL-NAME   AGE
linuxvirtualmachine.compute.azure.upbound.io/example   True    True     example         7m22s

NAME                                           READY   SYNCED   EXTERNAL-NAME   AGE
manageddisk.compute.azure.upbound.io/example   True    True     example         7m22s

NAME                                                                READY   SYNCED   EXTERNAL-NAME                                                                                                                                      AGE
virtualmachinedatadiskattachment.compute.azure.upbound.io/example   True    True     /subscriptions/XXXXXX/resourceGroups/example/providers/Microsoft.Compute/virtualMachines/example/dataDisks/example   7m22s

NAME                                                READY   SYNCED   EXTERNAL-NAME   AGE
networkinterface.network.azure.upbound.io/example   True    True     example         7m23s

NAME                                      READY   SYNCED   EXTERNAL-NAME   AGE
subnet.network.azure.upbound.io/example   True    True     example         7m23s

NAME                                              READY   SYNCED   EXTERNAL-NAME   AGE
virtualnetwork.network.azure.upbound.io/example   True    True     example         7m23s

Tested with Uptest

@turkenf
Copy link
Collaborator

turkenf commented Nov 8, 2023

/test-examples="examples/compute/virtualmachinedatadiskattachment.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @prfj, I left a comment for you.

Could you please do the manual tests of the resource and fill in the description section?

config/externalname.go Outdated Show resolved Hide resolved
@prfj
Copy link
Contributor Author

prfj commented Nov 9, 2023

@turkenf Can you run a new uptest now ? I've added selectors/references and fixed the example file

Could you please do the manual tests of the resource and fill in the description section?

I've tested using the "Manual Test" method what kind of evidence you want me to put on description ?

@turkenf
Copy link
Collaborator

turkenf commented Nov 9, 2023

@prfj, just put the output of kubectl get managed and could you please try to trigger uptest? Since you are a contributor, I expect it to work, if not I will trigger.

@prfj
Copy link
Contributor Author

prfj commented Nov 9, 2023

/test-examples="examples/compute/virtualmachinedatadiskattachment.yaml"

@prfj
Copy link
Contributor Author

prfj commented Nov 13, 2023

@turkenf applied sugestions please check

@turkenf
Copy link
Collaborator

turkenf commented Nov 13, 2023

/test-examples="examples/compute/virtualmachinedatadiskattachment.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort @prfj, LGTM.

@turkenf turkenf merged commit 0e4badc into crossplane-contrib:main Nov 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for azurerm_virtual_machine_data_disk_attachment resource
2 participants