Issue 19 #1435
Issue 19 #1435
Conversation
This reverts commit 0b5d06c.
…loyer Oscm barclamp refactor deployer
disable container logging to messages
removed superfluous comments and files
| server_nodes = nodes.select { |n| n.intended_role == "controller" } | ||
| server_nodes = [nodes.first] if server_nodes.empty? | ||
|
|
||
| base["deployment"][@bc_name]["elements"] = { |
There was a problem hiding this comment.
Style/MultilineIfModifier: Favor a normal unless-statement over a modifier clause in a multiline statement. (https://github.com/bbatsov/ruby-style-guide#no-multiline-if-modifiers)
| def proposal_dependencies(role) | ||
| answer = [] | ||
| ["heat"].each do |dep| | ||
| answer << { "barclamp" => dep, "inst" => role.default_attributes[@bc_name]["#{dep}_instance"] } |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [101/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)
| "suse" => "< 12.1", | ||
| "windows" => "/.*/" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Style/TrailingCommaInLiteral: Avoid comma after the last item of a hash. (https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas)
| "data-sslcert" => "/etc/escm/ssl/certs/signing_cert.pem", | ||
| "data-sslkey" => "/etc/escm/ssl/private/signing_key.pem" | ||
|
|
||
| #ssl_container |
| "data-showit" => "true", | ||
| "data-showit-target" => "#proxyauth_container", | ||
| "data-showit-direct" => "true" | ||
| #proxyauth_container |
| command = "scp #{args} #{escm_install_path}/user-data/deploy-escmserver #{ip_appserver}:#{escm_path}/config/" | ||
| command_out = shell_out(command) | ||
| command = "ssh #{args} #{ip_appserver} 'chmod 755 #{escm_path}/config/deploy-escmserver'" | ||
| command_out = shell_out(command) |
There was a problem hiding this comment.
Lint/UselessAssignment: Useless assignment to variable - command_out. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
| command = "scp #{args} #{escm_ssl_cacerts} #{ip_appserver}:#{escm_path}/ssl/escm.chain" | ||
| end | ||
| command = "scp #{args} #{escm_install_path}/user-data/deploy-escmserver #{ip_appserver}:#{escm_path}/config/" | ||
| command_out = shell_out(command) |
There was a problem hiding this comment.
Lint/UselessAssignment: Useless assignment to variable - command_out. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
| command_out = shell_out(command) | ||
| command = "scp #{args} #{escm_ssl_cacerts} #{ip_appserver}:#{escm_path}/ssl/escm.chain" | ||
| end | ||
| command = "scp #{args} #{escm_install_path}/user-data/deploy-escmserver #{ip_appserver}:#{escm_path}/config/" |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [115/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)
| command_out = shell_out(command) | ||
| command = "scp #{args} #{escm_ssl_keyfile} #{ip_appserver}:#{escm_path}/ssl/escm.key" | ||
| command_out = shell_out(command) | ||
| command = "scp #{args} #{escm_ssl_cacerts} #{ip_appserver}:#{escm_path}/ssl/escm.chain" |
There was a problem hiding this comment.
Lint/UselessAssignment: Useless assignment to variable - command. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
| command = "scp #{args} #{escm_ssl_certfile} #{ip_appserver}:#{escm_path}/ssl/escm.crt" | ||
| command_out = shell_out(command) | ||
| command = "scp #{args} #{escm_ssl_keyfile} #{ip_appserver}:#{escm_path}/ssl/escm.key" | ||
| command_out = shell_out(command) |
There was a problem hiding this comment.
Lint/UselessAssignment: Useless assignment to variable - command_out. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
Fixes #19