fix: avoid trigger a rustc bug which causes errors when build with target wasm32-unknown-unknown #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
force-pushed
the
pr/fix-wasm-target
branch
from
62821ad
to
6a61f37
Compare
…rget wasm32-unknown-unknown
yangby-cryptape
force-pushed
the
pr/fix-wasm-target
branch
from
6a61f37
to
e4867ca
Compare
driftluo
approved these changes
Oct 30, 2020
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Nov 3, 2020
2338: chore(deps): bump numext-fixed-uint from 1.4.0 to 1.6.0 r=doitian,driftluo a=yangby-cryptape Bumps [numext-fixed-uint](https://github.com/cryptape/rust-numext) from 0.1.4 to 0.1.6. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/cryptape/rust-numext/blob/v0.1.6/CHANGELOG.md">rust-numext's changelog</a>.</em></p> <blockquote> ### Major Updates - Use features to let all structs be optional. - Should NOT consider hashes as numbers. - Add methods to replace numerical methods for hashes. - `zero() -> empty()` - `is_zero() -> is_empty()` - `is_max() -> is_full()` - **BREAKING CHANGE** Remove `checked_neg(..)` for hashes. - Upgrade dependencies. - `quote v0.6 -> v1.0` - `syn v0.15 -> v1.0` - `proc-macro2 v0.4 -> v1.0` - Remove dependencies "proc-macro-hack" for crates in the workspace. - Update the minimum supported version of rust toolchain to `1.45.0` for the feature: [Stabilizing function-like procedural macros in expressions, patterns, and statements](https://blog.rust-lang.org/2020/07/16/Rust-1.45.0.html#stabilizing-function-like-procedural-macros-in-expressions-patterns-and-statements). - Use `thiserror` instead of `failure` since `failure` is officially deprecated. ### Fixed Bugs - Constructors can not handle short inputs correctly ([#42]). - `as_fixed_bytes_mut(&mut self)` return an immutable reference ([#42]). - Avoid trigger [a rustc bug](rust-lang/rust#75533) which causes errors when build with target `wasm32-unknown-unknown` ([#54]). </blockquote> </details> Full commits viewable in [compare view](cryptape/rust-numext@v0.1.4...v0.1.6). You can trigger a rebase of this PR by commenting `@yangby-cryptape rebase`. <small> #### Notice **The latest rust tool chain is not friendly for old proc-macros (there are a lot of issues, for example: compile errors).** **But after this PR, we still have few crates depend on very old proc-macros crates: `enum-display-derive` and `wasm-*`.** </small> [#42]: cryptape/rust-numext#42 [#54]: cryptape/rust-numext#54 Co-authored-by: Boyu Yang <[email protected]>
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Nov 3, 2020
2338: chore(deps): bump numext-fixed-uint from 1.4.0 to 1.6.0 r=doitian,driftluo a=yangby-cryptape Bumps [numext-fixed-uint](https://github.com/cryptape/rust-numext) from 0.1.4 to 0.1.6. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/cryptape/rust-numext/blob/v0.1.6/CHANGELOG.md">rust-numext's changelog</a>.</em></p> <blockquote> ### Major Updates - Use features to let all structs be optional. - Should NOT consider hashes as numbers. - Add methods to replace numerical methods for hashes. - `zero() -> empty()` - `is_zero() -> is_empty()` - `is_max() -> is_full()` - **BREAKING CHANGE** Remove `checked_neg(..)` for hashes. - Upgrade dependencies. - `quote v0.6 -> v1.0` - `syn v0.15 -> v1.0` - `proc-macro2 v0.4 -> v1.0` - Remove dependencies "proc-macro-hack" for crates in the workspace. - Update the minimum supported version of rust toolchain to `1.45.0` for the feature: [Stabilizing function-like procedural macros in expressions, patterns, and statements](https://blog.rust-lang.org/2020/07/16/Rust-1.45.0.html#stabilizing-function-like-procedural-macros-in-expressions-patterns-and-statements). - Use `thiserror` instead of `failure` since `failure` is officially deprecated. ### Fixed Bugs - Constructors can not handle short inputs correctly ([#42]). - `as_fixed_bytes_mut(&mut self)` return an immutable reference ([#42]). - Avoid trigger [a rustc bug](rust-lang/rust#75533) which causes errors when build with target `wasm32-unknown-unknown` ([#54]). </blockquote> </details> Full commits viewable in [compare view](cryptape/rust-numext@v0.1.4...v0.1.6). You can trigger a rebase of this PR by commenting `@yangby-cryptape rebase`. <small> #### Notice **The latest rust tool chain is not friendly for old proc-macros (there are a lot of issues, for example: compile errors).** **But after this PR, we still have few crates depend on very old proc-macros crates: `enum-display-derive` and `wasm-*`.** </small> [#42]: cryptape/rust-numext#42 [#54]: cryptape/rust-numext#54 Co-authored-by: Boyu Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid trigger a rustc bug which causes errors when build with target
wasm32-unknown-unknown.