Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump numext-fixed-uint from 1.4.0 to 1.6.0 #2338

Merged

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Oct 30, 2020

Bumps numext-fixed-uint from 0.1.4 to 0.1.6.

Changelog

Sourced from rust-numext's changelog.

Major Updates

  • Use features to let all structs be optional.
  • Should NOT consider hashes as numbers.
    • Add methods to replace numerical methods for hashes.
      • zero() -> empty()
      • is_zero() -> is_empty()
      • is_max() -> is_full()
    • BREAKING CHANGE Remove checked_neg(..) for hashes.
  • Upgrade dependencies.

Fixed Bugs

  • Constructors can not handle short inputs correctly (#42).
  • as_fixed_bytes_mut(&mut self) return an immutable reference (#42).
  • Avoid trigger a rustc bug which causes errors when build with target wasm32-unknown-unknown (#54).

Full commits viewable in compare view.

You can trigger a rebase of this PR by commenting @yangby-cryptape rebase.

Notice

The latest rust tool chain is not friendly for old proc-macros (there are a lot of issues, for example: compile errors).
But after this PR, we still have few crates depend on very old proc-macros crates: enum-display-derive and wasm-*.

@yangby-cryptape yangby-cryptape changed the title chore(deps): bump numext-fixed-uint from 1.4.0 to 1.5.0 chore(deps): bump numext-fixed-uint from 1.4.0 to 1.6.0 Oct 30, 2020
doitian
doitian previously approved these changes Nov 2, 2020
driftluo
driftluo previously approved these changes Nov 3, 2020
@driftluo
Copy link
Collaborator

driftluo commented Nov 3, 2020

enum-display-derive can be removed, wasm-* can upgrade

@driftluo
Copy link
Collaborator

driftluo commented Nov 3, 2020

bors r=doitian,driftluo

bors bot added a commit that referenced this pull request Nov 3, 2020
2338: chore(deps): bump numext-fixed-uint from 1.4.0 to 1.6.0 r=doitian,driftluo a=yangby-cryptape

Bumps [numext-fixed-uint](https://github.com/cryptape/rust-numext) from 0.1.4 to 0.1.6.

<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/cryptape/rust-numext/blob/v0.1.6/CHANGELOG.md">rust-numext's changelog</a>.</em></p>
<blockquote>

### Major Updates

- Use features to let all structs be optional.
- Should NOT consider hashes as numbers.
  - Add methods to replace numerical methods for hashes.
    - `zero() -> empty()`
    - `is_zero() -> is_empty()`
    - `is_max() -> is_full()`
  - **BREAKING CHANGE** Remove `checked_neg(..)` for hashes.
- Upgrade dependencies.
  - `quote v0.6 -> v1.0`
  - `syn v0.15 -> v1.0`
  - `proc-macro2 v0.4 -> v1.0`
  - Remove dependencies "proc-macro-hack" for crates in the workspace.
    - Update the minimum supported version of rust toolchain to `1.45.0` for the feature: [Stabilizing function-like procedural macros in expressions, patterns, and statements](https://blog.rust-lang.org/2020/07/16/Rust-1.45.0.html#stabilizing-function-like-procedural-macros-in-expressions-patterns-and-statements).
  - Use `thiserror` instead of `failure` since `failure` is officially deprecated.

### Fixed Bugs

- Constructors can not handle short inputs correctly ([#42]).
- `as_fixed_bytes_mut(&mut self)` return an immutable reference ([#42]).
- Avoid trigger [a rustc bug](rust-lang/rust#75533) which causes errors when build with target `wasm32-unknown-unknown` ([#54]).

</blockquote>
</details>

Full commits viewable in [compare view](cryptape/rust-numext@v0.1.4...v0.1.6).

You can trigger a rebase of this PR by commenting `@yangby-cryptape rebase`.

<small>

#### Notice

**The latest rust tool chain is not friendly for old proc-macros (there are a lot of issues, for example: compile errors).**
**But after this PR, we still have few crates depend on very old proc-macros crates: `enum-display-derive` and `wasm-*`.**

</small>

[#42]: cryptape/rust-numext#42
[#54]: cryptape/rust-numext#54

Co-authored-by: Boyu Yang <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 3, 2020

Build failed:

@yangby-cryptape yangby-cryptape dismissed stale reviews from driftluo and doitian via aabd0a3 November 3, 2020 06:42
@yangby-cryptape
Copy link
Collaborator Author

Merge branch only to update the file Cargo.lock manually.

@driftluo
Copy link
Collaborator

driftluo commented Nov 3, 2020

bors r=doitian,driftluo

@bors
Copy link
Contributor

bors bot commented Nov 3, 2020

Build succeeded:

@bors bors bot merged commit a6ebde0 into nervosnetwork:develop Nov 3, 2020
@yangby-cryptape yangby-cryptape deleted the pr/upgrade-numext-fixed-uint branch November 8, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants