Feature: replace ibc-hook with middleware

[thomas-nguy]

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

[codecov]

Codecov Report

Merging #511 (f429bba) into main (48dd672) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
+ Coverage   39.63%   39.91%   +0.27%     
==========================================
  Files          31       30       -1     
  Lines        1607     1596      -11     
==========================================
  Hits          637      637              
+ Misses        924      913      -11     
  Partials       46       46              

Impacted Files	Coverage Δ
x/cronos/keeper/keeper.go	68.86% <100.00%> (+3.60%)	⬆️

[tomtau]

🎉awesome.
I guess the problem statement here is: Problem: custom ibc-go fork used? the docs can perhaps have a brief update: https://github.com/crypto-org-chain/cronos/blob/main/docs/architecture/adr-002.md and https://github.com/crypto-org-chain/cronos/blob/main/docs/architecture/adr-004.md that the middleware implementation will override OnRecvPacket, OnAcknowledgmentPacket, and OnTimeoutPacket?

One potential thing to check is that there's a missing test for timeouts etc.: #398 -- we can see where it's at with the QA team... if ready soon, maybe we can merge the missing integration test first and run it against this?

[yihuang]

this seems not used anywhere?

[thomas-nguy]

yes this can be removed for now (this is needed if we need to write a "full" middleware)

[yihuang]

LGTM

[thomas-nguy]

I will merge this PR first as the current integration tests are passing.

I will work on the integration tests for ibc timeout/failure in another PR
#514

[adu-crypto]

lgtm