Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overload constructorof #14

Merged
merged 6 commits into from
Oct 9, 2019
Merged

overload constructorof #14

merged 6 commits into from
Oct 9, 2019

Conversation

jw3126
Copy link
Contributor

@jw3126 jw3126 commented Oct 1, 2019

@jw3126 jw3126 mentioned this pull request Oct 1, 2019
Open
12 tasks
@cstjean cstjean closed this Oct 1, 2019
@cstjean cstjean reopened this Oct 1, 2019
@jw3126
Copy link
Contributor Author

jw3126 commented Oct 1, 2019

We did not release ConstructionBase yet, so this will not pass CI and should not be merged yet.

@cstjean
Copy link
Owner

cstjean commented Oct 9, 2019

Should it now? I'm pretty eager to try the latest Setfield stuff 🙂 , it should be a big readability improvement for us.

@cstjean cstjean closed this Oct 9, 2019
@cstjean cstjean reopened this Oct 9, 2019
@jw3126
Copy link
Contributor Author

jw3126 commented Oct 9, 2019

Yes you can merge it now! If you want to try it with Setfield, you need the master branch. There is no Setfield release yet that works with ConstructionBase (there will be soonish).

@cstjean cstjean merged commit 4273f53 into cstjean:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jw3126 @cstjean