Operators are different in apply_energy_dependent_gh_cuts and apply_global_gh_cut

[aaguasca]

Dear developers, the operator in apply_energy_dependent_gh_cuts is >=, while in apply_global_gh_cut is >. Could you please explain to me why different operators are used? Thanks.

[rlopezcoto]

Hi @aaguasca , could you please point to the lines of code you are referring to?

[moralejo]

Probably a question for @chaimain. I don't think there is any reason. Although gammaness is a rather continuous parameter, and it should make basically no difference, it is better to do it consistently in both places.

[aaguasca]

Link to apply_global_gh_cut:

cta-lstchain/lstchain/io/event_selection.py

Line 90 in b1f83fa

return data[data["gh_score"] > self.global_gh_cut]

Link to apply_energy_dependent_gh_cuts:

cta-lstchain/lstchain/io/event_selection.py

Line 131 in b1f83fa

operator.ge,

[maxnoe]

I'd also say there is no real reason and there shouldn't be any consequences, since it is very unlikely that a float lies exactly on the cut. So just change to make it consistent, but don't expect any changes in the results.

[chaimain]

Thanks @aaguasca for spotting this discrepancy! Yes, as @moralejo and @maxnoe mentioned, there is no inherent reason for this distinction, and it is just something that I overlooked. I will fix it soon.

[chaimain]

Solved in #965