Remove hard-coded arguments in the energy-dependent cuts functions #965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the following new traits -
min_event_p_en_bin
: minimum number of events to check, in each energy bin. I have changed the default value to 100, instead of the earlier 10, which was too low to be meaningful with the standard bins we provide. Needs to be fixed after some more tests.min/max_gh/theta_cut
: Minimum and maximum cut values of gh_score (gammaness) and theta, while evaluating the percentile cuts.fill_theta_cut
: Fill value of theta cut, when the number of events is below the minimum value, in each energy bin. For gh_score cut, I use the maximum value of 1, as it is fixed.Also fixes the issue of #954 here to be more consistent PR, rather than #943. #942 can also follow this new change.
The example configs have been updated accordingly.
This will also help in fixing the error seen in running some tests in #961