Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script to perform data volume reduction on data taken with EvB6 (CTAR1 format) #1234

Merged
merged 12 commits into from
Mar 21, 2024
Merged

Script to perform data volume reduction on data taken with EvB6 (CTAR1 format) #1234

merged 12 commits into from
Mar 21, 2024

Conversation

moralejo
Copy link
Collaborator

@moralejo moralejo commented Feb 23, 2024 •
edited
Loading

Performs data volume reduction for EvB6 (CTAR1) data

@moralejo moralejo marked this pull request as draft February 23, 2024 15:35
@codecov Codecov
Copy link

codecov bot commented Feb 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.42857% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 72.95%. Comparing base (5ea3010) to head (911b572).
Report is 42 commits behind head on main.

Files Patch % Lines
lstchain/scripts/lstchain_r0g_to_r0v.py 90.52% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
+ Coverage   72.87%   72.95%   +0.08%     
==========================================
  Files         133      134       +1     
  Lines       13797    14016     +219     
==========================================
+ Hits        10054    10225     +171     
- Misses       3743     3791      +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moralejo
Copy link
Collaborator Author

moralejo commented Feb 24, 2024 •
edited
Loading

TBD: improve logging. Modify lstchain_dvr_pixselector to be faster (use just a fraction of the subruns in a run to determine the charge for pixel selection)
DONE in #1239

@moralejo moralejo marked this pull request as ready for review February 26, 2024 20:09
@moralejo moralejo requested a review from maxnoe February 26, 2024 20:09
morcuended
morcuended reviewed Feb 28, 2024
View reviewed changes
lstchain/scripts/lstchain_r0g_to_r0v.py Outdated Show resolved Hide resolved
lstchain/scripts/lstchain_r0g_to_r0v.py Outdated Show resolved Hide resolved
morcuended
morcuended reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. Just left some minor comments

lstchain/scripts/lstchain_r0g_to_r0v.py Show resolved Hide resolved
lstchain/scripts/lstchain_r0g_to_r0v.py Outdated Show resolved Hide resolved
morcuended
morcuended reviewed Mar 21, 2024
View reviewed changes
setup.py Show resolved Hide resolved
@moralejo moralejo merged commit 3fce3e2 into main Mar 21, 2024
9 checks passed
@moralejo moralejo deleted the dvr_script branch March 21, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morcuended morcuended morcuended approved these changes

@maxnoe maxnoe Awaiting requested review from maxnoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moralejo @maxnoe @morcuended