-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute cleaning thresholds in lstchain_dvr_pixselector #1239
Conversation
Also corrected a small error in earlier changes: in case more than one run was processed (in the "compute_dvr_settings" mode) the total number of (DL1) subruns processed was 10, instead of 10 per run, as intended. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1239 +/- ##
==========================================
+ Coverage 72.86% 72.93% +0.07%
==========================================
Files 133 133
Lines 13819 13864 +45
==========================================
+ Hits 10069 10112 +43
- Misses 3750 3752 +2 ☔ View full report in Codecov by Sentry. |
Now the mode for the run is taken, safer against car flashes and other light sources
When used for determining the settings for the Data Volume Reduction (DVR) of a given run, the program now outputs also a .json file (adapted to the NSB conditions) for use in the lstchain_dl1ab step