Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute cleaning thresholds in lstchain_dvr_pixselector #1239

Merged
merged 13 commits into from
Mar 1, 2024

Conversation

moralejo
Copy link
Collaborator

When used for determining the settings for the Data Volume Reduction (DVR) of a given run, the program now outputs also a .json file (adapted to the NSB conditions) for use in the lstchain_dl1ab step

@moralejo
Copy link
Collaborator Author

Also corrected a small error in earlier changes: in case more than one run was processed (in the "compute_dvr_settings" mode) the total number of (DL1) subruns processed was 10, instead of 10 per run, as intended.

@moralejo moralejo marked this pull request as ready for review February 27, 2024 17:27
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 72.93%. Comparing base (a453522) to head (68d0475).
Report is 6 commits behind head on main.

Files Patch % Lines
lstchain/scripts/lstchain_dvr_pixselector.py 85.41% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1239      +/-   ##
==========================================
+ Coverage   72.86%   72.93%   +0.07%     
==========================================
  Files         133      133              
  Lines       13819    13864      +45     
==========================================
+ Hits        10069    10112      +43     
- Misses       3750     3752       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moralejo moralejo marked this pull request as draft February 27, 2024 19:46
@moralejo moralejo marked this pull request as ready for review February 28, 2024 16:24
@rlopezcoto rlopezcoto merged commit 0ad6729 into main Mar 1, 2024
9 checks passed
@rlopezcoto rlopezcoto deleted the high_NSB_cleaning branch March 1, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants