Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ctapipe_io_lst version and __version__ of lstchain #253

Merged
merged 5 commits into from
Dec 17, 2019
Merged

Update ctapipe_io_lst version and __version__ of lstchain #253

merged 5 commits into from
Dec 17, 2019

Conversation

rlopezcoto
Copy link
Contributor

@maxnoe
Copy link
Member

maxnoe commented Dec 17, 2019

The path needs to be adapted. Or better be made as an argument for update_release_version. Otherwise the installed version will be 'unknown'.

See https://github.com/cta-observatory/ctapipe_io_lst/blob/9c96587164e86d8be1c5e38c568e37a9e1143704/version.py#L36

A better solution would be to define a base dir for the version file.

@rlopezcoto
Copy link
Contributor Author

I changed the path, now it should be fine

@rlopezcoto rlopezcoto merged commit b330595 into cta-observatory:master Dec 17, 2019
@rlopezcoto rlopezcoto deleted the update_ctapipe_io_lst branch December 17, 2019 16:51
@morcuended
Copy link
Member

Hi @rlopezcoto, environment.yml is still pointing to ctapipe_io_lst v0.3.1 instead of the new release v0.4.0

@rlopezcoto rlopezcoto mentioned this pull request Dec 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxnoe maxnoe maxnoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlopezcoto @maxnoe @morcuended