Fix pip install #22
Merged
Fix pip install #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rlopezcoto
reviewed
Dec 17, 2019
There was a problem hiding this comment.
Hi @maxnoe, thanks for this fix.
Not sure about the update of protozfits, we have not tested any new version so it would probably be better to keep it like this for the time being, what are the main updates?
rlopezcoto
approved these changes
Dec 17, 2019
|
No idea, just saw it when looking for the lonk |
FrancaCassol
approved these changes
Dec 17, 2019
|
I think this can be merges @maxnoe, thanks a lot for the fix! After this, we will make a new release |
This was referenced Apr 22, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpticsDescription.from_name, so this works without ctapipe-extra