Do not redo link to pro directory if already correct

[FrancaCassol]

No description provided.

[codecov]

Codecov Report

Merging #896 (eca3adf) into master (b22332d) will increase coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   83.83%   84.29%   +0.46%     
==========================================
  Files          77       84       +7     
  Lines        5968     6704     +736     
==========================================
+ Hits         5003     5651     +648     
- Misses        965     1053      +88     

Impacted Files	Coverage Δ
lstchain/__init__.py	77.27% <0.00%> (-5.09%)	⬇️
lstchain/io/config.py	100.00% <0.00%> (ø)
lstchain/io/__init__.py	100.00% <0.00%> (ø)
lstchain/io/tests/test_config.py	100.00% <0.00%> (ø)
lstchain/high_level/tests/test_hdus.py	100.00% <0.00%> (ø)
lstchain/high_level/hdu_table.py	92.18% <0.00%> (ø)
lstchain/data/normalised_pulse_template.py	100.00% <0.00%> (ø)
...chain/data/tests/test_normalised_pulse_template.py	100.00% <0.00%> (ø)
lstchain/data/__init__.py	100.00% <0.00%> (ø)
lstchain/high_level/__init__.py	100.00% <0.00%> (ø)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22332d...eca3adf. Read the comment docs.

[maxnoe]

Could you maybe put that code into a function

def create_pro_link(output_dir):

It is duplicated 4 times and you now had to make a change at 4 locations in exactly the same way.

[FrancaCassol]

Hi @maxnoe,

where do you want to put this function?

[maxnoe]

@FrancaCassol maybe create a new module lstchain/onsite.py?

I wanted to also refactor the rest of the duplicated code in the onsite scripts, e.g. by introducing functions like:

def find_drs4_baseline_run(run_id, base):
    ...

[FrancaCassol]

I see, do we want to do it now or we better keep it for later?

[maxnoe]

We can also do it in one go later...

[rlopezcoto]

wait, I was modifying it after talking to @FrancaCassol

[FrancaCassol]

If there are other changes I think it is better to do all later.
I would merge it as it is now

[rlopezcoto]

@FrancaCassol maybe create a new module lstchain/onsite.py?

I created instead a path.py module inside scripts/onsite, does that sound good?

[FrancaCassol]

I liked better the onsite.py idea that is more general.