Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct latest changes #900

Merged
merged 4 commits into from
Feb 2, 2022
Merged

Correct latest changes #900

merged 4 commits into from
Feb 2, 2022

Conversation

rlopezcoto
Copy link
Contributor

Correct a few things related to latest PRs:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@gabemery gabemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems correct.

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #900 (8562dbe) into master (6f3fbc2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #900   +/-   ##
=======================================
  Coverage   84.68%   84.68%           
=======================================
  Files          77       77           
  Lines        6074     6074           
=======================================
  Hits         5144     5144           
  Misses        930      930           
Impacted Files Coverage Δ
lstchain/image/modifier.py 87.91% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3fbc2...8562dbe. Read the comment docs.

@rlopezcoto rlopezcoto merged commit ca9f1fc into master Feb 2, 2022
@maxnoe maxnoe deleted the correct_latest_changes branch February 2, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants