Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DL3 energy-dependent alpha cut #942

Merged
merged 15 commits into from
May 2, 2022
Merged

Conversation

SeiyaNozaki
Copy link
Collaborator

This PR implements energy-dependent alpha cut for the IRF/DL3 production.
The same solution as energy-dependent g/h cuts is basically used for the energy-dependent alpha cut.
(create a separate temporary header to save energy-dependent alpha cuts in IRF)
Since the alpha cut is already applied to observational DL3 data, there is no need to modify gammapy.

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #942 (90a93b7) into master (33a6355) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
+ Coverage   85.41%   85.56%   +0.15%     
==========================================
  Files          78       78              
  Lines        6501     6555      +54     
==========================================
+ Hits         5553     5609      +56     
+ Misses        948      946       -2     
Impacted Files Coverage Δ
lstchain/io/event_selection.py 100.00% <100.00%> (ø)
lstchain/io/tests/test_eventselection.py 100.00% <100.00%> (ø)
lstchain/tools/lstchain_create_dl3_file.py 92.59% <100.00%> (+2.59%) ⬆️
lstchain/tools/lstchain_create_irf_files.py 93.95% <100.00%> (+0.54%) ⬆️
lstchain/tools/tests/test_tools.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a6355...90a93b7. Read the comment docs.

Copy link
Contributor

@chaimain chaimain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review.
It looks good to me in general.

lstchain/tools/lstchain_create_irf_files.py Outdated Show resolved Hide resolved
lstchain/io/event_selection.py Outdated Show resolved Hide resolved
chaimain
chaimain previously approved these changes Apr 4, 2022
@chaimain chaimain requested a review from maxnoe April 25, 2022 09:07
@moralejo moralejo merged commit f00e275 into master May 2, 2022
@moralejo moralejo deleted the dl3_energy_dependent_alpha_cut branch May 2, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants