-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DL3 energy-dependent alpha cut #942
Conversation
… lstchain_create_dl3_file
Codecov Report
@@ Coverage Diff @@
## master #942 +/- ##
==========================================
+ Coverage 85.41% 85.56% +0.15%
==========================================
Files 78 78
Lines 6501 6555 +54
==========================================
+ Hits 5553 5609 +56
+ Misses 948 946 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review.
It looks good to me in general.
This PR implements energy-dependent alpha cut for the IRF/DL3 production.
The same solution as energy-dependent g/h cuts is basically used for the energy-dependent alpha cut.
(create a separate temporary header to save energy-dependent alpha cuts in IRF)
Since the alpha cut is already applied to observational DL3 data, there is no need to modify gammapy.