Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctapipe v0.15 #50

Closed
wants to merge 3 commits into from
Closed

Ctapipe v0.15 #50

wants to merge 3 commits into from

Conversation

aleberti
Copy link
Collaborator

@aleberti aleberti commented Jun 3, 2022

Updating to ctapipe v0.15 (needed to update magic-cta-pipe to same ctapipe version, in order to use gammapy v0.20).

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #50 (1d0752c) into master (6bf3f1d) will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   88.88%   89.12%   +0.23%     
==========================================
  Files           9        9              
  Lines         828      846      +18     
==========================================
+ Hits          736      754      +18     
  Misses         92       92              
Impacted Files Coverage Δ
ctapipe_io_magic/tests/test_magic_event_source.py 100.00% <0.00%> (ø)
ctapipe_io_magic/__init__.py 86.28% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf3f1d...1d0752c. Read the comment docs.

@YoshikiOhtani
Copy link
Collaborator

Thanks Alessio, as we discussed privately let's wait to merge this to the master until magic-cta-pipe is updated to the same version of ctapipe.

@aleberti
Copy link
Collaborator Author

Closing this because superseded by #57 .

@aleberti aleberti closed this Dec 12, 2022
@aleberti aleberti deleted the ctapipe_v0.15 branch April 19, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants