Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctapipe v0.17 #57

Merged
merged 26 commits into from
Apr 26, 2023
Merged

ctapipe v0.17 #57

merged 26 commits into from
Apr 26, 2023

Conversation

ellijobst
Copy link
Collaborator

No description provided.

@ellijobst ellijobst changed the title Changes in configuration to move to ctapipe v0.17 ctapipe v0.17 Dec 12, 2022
@aleberti aleberti mentioned this pull request Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Patch coverage: 95.91% and project coverage change: +0.37 🎉

Comparison is base (0f83b1d) 88.23% compared to head (a89ab9a) 88.60%.

❗ Current head a89ab9a differs from pull request most recent head 9742299. Consider uploading reports for the commit 9742299 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   88.23%   88.60%   +0.37%     
==========================================
  Files           9        9              
  Lines         901      948      +47     
==========================================
+ Hits          795      840      +45     
- Misses        106      108       +2     
Impacted Files Coverage Δ
ctapipe_io_magic/__init__.py 85.58% <94.87%> (+0.48%) ⬆️
ctapipe_io_magic/tests/test_magic_event_source.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aleberti aleberti requested a review from jsitarek April 19, 2023 07:40
Copy link
Collaborator

@jsitarek jsitarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one change requested, plus one confirmation

ctapipe_io_magic/__init__.py Outdated Show resolved Hide resolved
ctapipe_io_magic/__init__.py Show resolved Hide resolved
ctapipe_io_magic/constants.py Outdated Show resolved Hide resolved
@aleberti
Copy link
Collaborator

@jsitarek I think you need to update your review, because it tells me that changes are still requested

@aleberti aleberti merged commit 8e683c6 into master Apr 26, 2023
@aleberti aleberti deleted the ctapipe_v0.17 branch April 26, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants