Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #157

Draft
wants to merge 9 commits into
base: Torino
Choose a base branch
from
Draft

Tests #157

wants to merge 9 commits into from

Conversation

Elisa-Visentin
Copy link
Collaborator

More tests for the 4 LSTs pipeline

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (15376a5) 41.88% compared to head (85b393f) 43.53%.
Report is 9 commits behind head on Torino.

❗ Current head 85b393f differs from pull request most recent head e2adffe. Consider uploading reports for the commit e2adffe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           Torino     #157      +/-   ##
==========================================
+ Coverage   41.88%   43.53%   +1.64%     
==========================================
  Files          47       49       +2     
  Lines        5567     5673     +106     
==========================================
+ Hits         2332     2470     +138     
+ Misses       3235     3203      -32     
Files Coverage Δ
magicctapipe/conftest.py 99.74% <100.00%> (+<0.01%) ⬆️
magicctapipe/io/__init__.py 100.00% <ø> (ø)
magicctapipe/io/io.py 92.54% <100.00%> (+6.57%) ⬆️
magicctapipe/io/tests/test_io.py 100.00% <100.00%> (ø)
magicctapipe/io/tests/test_io_monly.py 100.00% <100.00%> (ø)
...tapipe/scripts/lst1_magic/tests/test_mc_dl0_dl1.py 92.30% <92.30%> (ø)
...apipe/scripts/lst1_magic/tests/test_coincidence.py 86.66% <86.66%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aleberti
Copy link
Collaborator

@Elisa-Visentin is this supposed to be merged after #170 ? or can it be merged before?

@Elisa-Visentin
Copy link
Collaborator Author

Here I am implementing some tests while we are upgrading the pipeline. This will be merged with/after the next pipeline PR (i.e., upgrades of the RFs, Dl2, DL3...). PR #170 is about semi-automatic scripts, so not dependent on tests.

@aleberti
Copy link
Collaborator

ok, I see. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants