Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment of docs in CI #159

Merged
merged 25 commits into from
Oct 23, 2023
Merged

Add deployment of docs in CI #159

merged 25 commits into from
Oct 23, 2023

Conversation

aleberti
Copy link
Collaborator

See title.

@aleberti aleberti marked this pull request as draft October 20, 2023 08:44
@aleberti
Copy link
Collaborator Author

Converting to draft, I cannot install correctly dependencies needed for building the docs in the CI. At the moment I am bound to wait for #154 to be merged, I cannot update environment and stuff to ctapipe v0.19 otherwise it will break that PR. Then #153 can be merged, followed by #157 . I guess then the RF->DL3 PR should be next (together with the PR with the semi-automatic scripts?), and finally #148 and #149, and then this one. So, for the moment, I wait...

@aleberti
Copy link
Collaborator Author

So this also means that I will produce the documentation site (https://magic-cta-pipe.readthedocs.io/en/latest/index.html) manually until this is merged.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f489ed2) 36.63% compared to head (a637a28) 36.63%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   36.63%   36.63%           
=======================================
  Files          45       45           
  Lines        5238     5238           
=======================================
  Hits         1919     1919           
  Misses       3319     3319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aleberti
Copy link
Collaborator Author

It seems I managed to fix environment and stuff for this to work for both docs and tests. This can be eventually merged even before the other PR mentioned in the previous message.

@aleberti aleberti marked this pull request as ready for review October 23, 2023 19:47
@aleberti aleberti merged commit b35fd4a into master Oct 23, 2023
8 checks passed
@aleberti aleberti deleted the automatic_docs branch October 23, 2023 19:52
@aleberti aleberti added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 2, 2023
Elisa-Visentin pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant