Remove unworking integration tests #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests currently don't run, don't work, and are outdated. Removing dead code for now with the plan to re-introduce integration tests.
drwl
force-pushed
the
drwl/remove-bad-integration-tests
branch
from
72c73b5
to
fd34058
Compare
|
@ctran any thoughts against merging this? I'll add an issue for help-wanted to add integration tests to make sure we keep track. |
Dockerfile was added in #710 to make it easier to run integration tests locally.
|
@ctran gonna merge this in and if we decide we want to keep it we can revert this commit. |
This was referenced Jan 27, 2020
drwl
added a commit
that referenced
this pull request
Feb 1, 2020
There's some left over files from #725, this change cleans up the remaining files in `spec/integration/`.
drwl
added a commit
that referenced
this pull request
Feb 1, 2020
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
`spec/integration` contains a lot of files that were used for integration tests. They stopped were [disabled in 2014](ctran@9540121#diff-78ddf877ecc2a9344997ef077a77955a) and haven't been working since. Removing because those tests don't run, don't work, and are outdated. The plan is to re-introduce integration tests sometime in the future.
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
There's some left over files from ctran#725, this change cleans up the remaining files in `spec/integration/`.
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec/integrationcontains a lot of files that were used for integration tests. They stopped were disabled in 2014 and haven't been working since.Removing because those tests don't run, don't work, and are outdated. The plan is to re-introduce integration tests sometime in the future.