Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration framework to project #733

Closed
drwl opened this issue Jan 20, 2020 · 0 comments · Fixed by #747
Closed

Add integration framework to project #733

drwl opened this issue Jan 20, 2020 · 0 comments · Fixed by #747

Comments

@drwl
Copy link
Collaborator

drwl commented Jan 20, 2020

Summary

This project can be used in many different environments and scenarios. Can be run using different versions of Ruby across different versions of Rails. Having integration tests that can help this project move forward and stay up to date when new versions come up.

Would like to add or fix these type of tests. Currently there exist non-working integration tests that haven't been functional since ~2014. A lot has changed since then. Bundler has come a long way for managing dependencies on projects and CI has improved a lot so we may be able to leverage matrix builds.

Next Steps

Having a working bare bones integration test (this will take a good amount of effort)

@drwl drwl closed this as completed in #747 Feb 11, 2020
drwl added a commit that referenced this issue Feb 11, 2020
Adds integration tests to the project that's able to run in CI across different ruby versions.

* Adds a Rails 5.2.4.1 app
* Adds a Rails 6.0.2.1 app

Fixes #733
vfonic pushed a commit to vfonic/annotate_models that referenced this issue May 8, 2020
Adds integration tests to the project that's able to run in CI across different ruby versions.

* Adds a Rails 5.2.4.1 app
* Adds a Rails 6.0.2.1 app

Fixes ctran#733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant