Add integration tests to project #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used the following command: `rails new rails_6.0.2.1 --skip-git --skip-sprockets --skip-spring --skip-javascript --skip-turbolinks --skip-test-unit` Then `rubocop --auto-gen-config` to ignore rubocop violations.
Ran rails db:migrate
Generated using `rails g model Task content:string count:integer status:boolean`
* Ran the migration for Task model. * Ran Rubocop to ignore files in Rails app.
Closed
Used the following command: `rails _5.2.4.1_ new rails_5.2.4.1` Then I deleted /.git that was auto generated.
Used command: `bin/rails g model Task content:string count:integer status:boolean`
* Update activerecord constraint to support older Ruby versions Active Record 6 only supports Ruby versions >= 2.5. This means that Ruby 2.4 will not be supported. By limiting the Active Record version we'll be able to support Ruby 2.4. * Move bundle install step into each integration test
|
@ctran added if you wanna take a look |
|
@nard-tech could you take a look and tell me what you think? |
|
@drwl |
Sure will do |
* Used `bin/spring binstub --remove --all` to remove spring from app. * Update Gemfile.lock when removing Spring gem.
In a previous commit, spec/integration/**/* was excluded from Rubocop linter rules. .rubocop.yml inherits from .rubocop_todo.yml before looking at exclusions defined in .rubocop.yml, so spec/integration/rails* was not being ignored.
A hacky approach to solving these constants polluting the global namespace.
|
Note for any future visitors, ad4f9ba does something hacky which is to have the constants be uniquely named. The constants defined in the
Definitely an area to improve. |
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
Adds integration tests to the project that's able to run in CI across different ruby versions. * Adds a Rails 5.2.4.1 app * Adds a Rails 6.0.2.1 app Fixes ctran#733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration tests to the project that's able to run in CI across different ruby versions.
Fixes #733