URL Signing #1
Open
URL Signing #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestelfer
approved these changes
Jul 22, 2020
Comment on lines
+658
to
+659
| code: 'DecodeRequest::CannotReadPath', | ||
| message: 'The URL path you provided could not be read. Please ensure that it is properly formed according to the solution documentation.' |
There was a problem hiding this comment.
My reading of the diff makes this error message surprising. I didn't read the whole thing though.
| }); | ||
| } | ||
|
|
||
| const signature = crypto.createHmac("sha1", signKey).update(base64).digest("hex"); |
There was a problem hiding this comment.
SHA1 is broken. I know this is signing, not encryption, but I question this algorithm choice. I'd expect SHA-256 at minimum. What algorithm does AWS use for its S3 URL signing? I doubt it's SHA1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces URL signing to the AWS serverless image handler solution. It has been shamelessly stolen from this PR
You may be asking yourself why we are not using the builtin cloudfront URL signing... Unfortunately, the cloudfront solution does not support our use case:
As a result, the functionality has been added to the lambda function.
It looks like this will be incorporated directly into the AWS supported solution in the not too distant future at which point we can chuck this and use their solution unmodified.