forked from aws-solutions/serverless-image-handler
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL Signing #1
Open
matthewtapper
wants to merge
1
commit into
master
Choose a base branch
from
mt/url-signing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
URL Signing #1
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -641,6 +641,25 @@ describe('decodeRequest()', function() { | |
}); | ||
}); | ||
}); | ||
describe('004/signedPath', function() { | ||
it(`Should throw an error if signature is invalid`, function() { | ||
// Arrange | ||
process.env = { | ||
SIGNATURE_KEY : "mySecretKey" | ||
} | ||
const path = 'eyJlZGl0cyI6eyJncmF5c2NhbGUiOiJ0cnVlIiwicm90YXRlIjo5MCwiZmxpcCI6InRydWUifX0--invalid-signature' | ||
// Act | ||
const imageRequest = new ImageRequest(); | ||
// Assert | ||
assert.throws(function() { | ||
imageRequest.decodeRequest(event); | ||
}, Object, { | ||
status: 400, | ||
code: 'DecodeRequest::CannotReadPath', | ||
message: 'The URL path you provided could not be read. Please ensure that it is properly formed according to the solution documentation.' | ||
Comment on lines
+658
to
+659
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My reading of the diff makes this error message surprising. I didn't read the whole thing though. |
||
}); | ||
}); | ||
}); | ||
}); | ||
|
||
// ---------------------------------------------------------------------------- | ||
|
@@ -755,3 +774,87 @@ describe('getOutputFormat()', function () { | |
}); | ||
}); | ||
}); | ||
|
||
|
||
// ---------------------------------------------------------------------------- | ||
// verifySignature() | ||
// ---------------------------------------------------------------------------- | ||
|
||
describe('verifySignature()', function() { | ||
describe('001/noSignatureKey', function() { | ||
it(`Should pass if a valid base64-encoded path has been specified`, function() { | ||
// Arrange | ||
const path = 'eyJidWNrZXQiOiJidWNrZXQtbmFtZS1oZXJlIiwia2V5Ijoia2V5LW5hbWUtaGVyZSJ9' | ||
|
||
// Act | ||
const imageRequest = new ImageRequest(); | ||
const result = imageRequest.verifySignature(path); | ||
|
||
// Assert | ||
const expectedResult = 'eyJidWNrZXQiOiJidWNrZXQtbmFtZS1oZXJlIiwia2V5Ijoia2V5LW5hbWUtaGVyZSJ9' | ||
assert.deepEqual(result, expectedResult); | ||
}); | ||
}); | ||
|
||
describe('002/validSignature', function() { | ||
it(`Should pass if a valid signature has been specified`, function() { | ||
// Arrange | ||
process.env = { | ||
SIGNATURE_KEY : "mySecretKey" | ||
} | ||
const path = 'eyJidWNrZXQiOiJidWNrZXQtbmFtZS1oZXJlIiwia2V5Ijoia2V5LW5hbWUtaGVyZSJ9--640b43f6c1fede17c301b23338b4eb4d7d462ce6' | ||
|
||
// Act | ||
const imageRequest = new ImageRequest(); | ||
const result = imageRequest.verifySignature(path); | ||
|
||
// Assert | ||
const expectedResult = 'eyJidWNrZXQiOiJidWNrZXQtbmFtZS1oZXJlIiwia2V5Ijoia2V5LW5hbWUtaGVyZSJ9' | ||
assert.deepEqual(result, expectedResult); | ||
}); | ||
}); | ||
|
||
describe('003/invalidSignature', function() { | ||
it(`Should throw an error if an invalid signature has been specified`, function() { | ||
// Arrange | ||
process.env = { | ||
SIGNATURE_KEY : "mySecretKey" | ||
} | ||
const path = 'eyJlZGl0cyI6eyJncmF5c2NhbGUiOiJ0cnVlIiwicm90YXRlIjo5MCwiZmxpcCI6InRydWUifX0--640b43f6c1fede17c301b23338b4eb4d7d462ce6' | ||
|
||
// Act | ||
const imageRequest = new ImageRequest(); | ||
|
||
// Assert | ||
assert.throws(function() { | ||
imageRequest.verifySignature(path); | ||
}, Object, { | ||
status: 400, | ||
code: 'DecodeRequest::InvalidSignature', | ||
message: 'The signature you provided could not be verified.' | ||
}); | ||
}); | ||
}); | ||
|
||
describe('004/noSignature', function() { | ||
it(`Should throw an error if signature has not been specified`, function() { | ||
// Arrange | ||
process.env = { | ||
SIGNATURE_KEY : "mySecretKey" | ||
} | ||
const path = 'eyJlZGl0cyI6eyJncmF5c2NhbGUiOiJ0cnVlIiwicm90YXRlIjo5MCwiZmxpcCI6InRydWUifX0' | ||
|
||
// Act | ||
const imageRequest = new ImageRequest(); | ||
|
||
// Assert | ||
assert.throws(function() { | ||
imageRequest.verifySignature(path); | ||
}, Object, { | ||
status: 400, | ||
code: 'DecodeRequest::MissingSignature', | ||
message: 'The signature is missing.' | ||
}); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHA1 is broken. I know this is signing, not encryption, but I question this algorithm choice. I'd expect SHA-256 at minimum. What algorithm does AWS use for its S3 URL signing? I doubt it's SHA1.