Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to the workflow config to force use of compat mode #6097

Merged
merged 4 commits into from
May 13, 2024
Merged

Add an option to the workflow config to force use of compat mode #6097

merged 4 commits into from
May 13, 2024

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented May 10, 2024

Works with cylc/cylc-rose#322 to close cylc/cylc-rose#319.

Functional test provided by metomi/rose#2779

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • This small change does not require documentation
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim requested a review from oliver-sanders May 10, 2024 14:12
@wxtim wxtim self-assigned this May 10, 2024
@wxtim wxtim added this to the 8.2.x milestone May 10, 2024
This was referenced May 10, 2024
Merged
Merged
oliver-sanders
oliver-sanders reviewed May 10, 2024
View reviewed changes
cylc/flow/config.py Outdated Show resolved Hide resolved
@wxtim wxtim requested a review from oliver-sanders May 13, 2024 07:13
oliver-sanders
oliver-sanders approved these changes May 13, 2024
View reviewed changes
cylc/flow/config.py Outdated Show resolved Hide resolved
cylc/flow/workflow_files.py Show resolved Hide resolved
@wxtim wxtim changed the base branch from 8.2.x to master May 13, 2024 09:30
@wxtim wxtim modified the milestones: 8.2.x, 8.3.0 May 13, 2024
@oliver-sanders oliver-sanders added the non-cylc bug This is a bug, but not in Cylc label May 13, 2024
@MetRonnie MetRonnie self-requested a review May 13, 2024 10:21
MetRonnie
MetRonnie reviewed May 13, 2024
View reviewed changes
cylc/flow/config.py Outdated Show resolved Hide resolved
@wxtim @MetRonnie
Update cylc/flow/config.py
3d41785 
Co-authored-by: Ronnie Dutta <[email protected]>
@MetRonnie MetRonnie merged commit 877388d into cylc:master May 13, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@wxtim wxtim

Labels
non-cylc bug This is a bug, but not in Cylc
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

compat mode ignored
3 participants
@wxtim @oliver-sanders @MetRonnie