Fix.cylc rose issue 319 #322
Conversation
There was a problem hiding this comment.
Note, the issue is tagged against 1.4.0 not 1.3.x. We can leave this on the bugfix milestones, but will need to amend the cylc-flow dependency in setup.cfg to prevent this from being used with an incompatible release of cylc-flow if we were to make another bugfix release before the cylc 8.3 meta-release.
|
(tests will fail until upstream PR merged) |
|
Could do with a quick rebase now that the sync PR is in. |
| def get_compat_mode(run_dir: Union[str, Path]) -> bool: | ||
| """Check whether this is a Cylc 7 Back compatibility mode workflow: | ||
|
|
||
| See https://github.com/cylc/cylc-rose/issues/319 | ||
|
|
||
| Args: | ||
| run_dir: Cylc workflow run directory. | ||
| """ | ||
| return (Path(run_dir) / WorkflowFiles.SUITE_RC).exists() |
There was a problem hiding this comment.
Couldn't we just import and use cylc.flow.workflow_files.check_deprecation?
There was a problem hiding this comment.
I guess that we could, but I'd rather not risk change the state of the cylc.flow.flags.cylc7_back_compat flag if at all possible: This approach means that information is only really flowing from Cylc flow into Cylc Rose.
…ening the flow-processed.cylc file, and override the compat mode in the workflow config if required.
wxtim
force-pushed
the
fix.cylc-rose_issue_319
branch
from
079d63c
to
bea2f90
Compare
|
Kicking tests |
Works with cylc/cylc-flow#6097 to close #319.
Functional test provided by metomi/rose#2779
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.