-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update blob-util, remove @types/blog-util #7784
Conversation
jennifer-shehane
commented
Jun 23, 2020
- Close Replace dep @types/blob-util (it's deprecated) #6001
…ns (#7746) Co-authored-by: Jessica Sachs <[email protected]>
* Add UTM parameters to Dashboard login buttons * Revert "Add UTM parameters to Dashboard login buttons" This reverts commit 568f12e. * Add UTM parameters to Dashboard login buttons * utmCode camel case Co-authored-by: Zach Bloomquist <[email protected]> * Add desktop-gui integration tests for utm code * Add server unit tests for utm code Co-authored-by: Zach Bloomquist <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Jennifer Shehane <[email protected]>
* Option to disable Cypress the verbose results to stdout --quiet mode to disable the verbose results to stdout but still use specified formatter * Update cli/schema/cypress.schema.json Co-authored-by: Jennifer Shehane <[email protected]> * Cypress module support for --quiet Cypress module support for --quiet * Apply suggestions from code review Co-authored-by: Zach Bloomquist <[email protected]> * Address feedback Address feedback, thanks Co-authored-by: Jennifer Shehane <[email protected]> Co-authored-by: Zach Bloomquist <[email protected]>
Co-authored-by: Jennifer Shehane <[email protected]>
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
I don't remember correctly. But I failed at the last attempt, because the API has been changed in blob-util 2.x. So, some codes and even documentation should be changed because of the breaking change. I'll check them out tomorrow. |
@sainthkh Thanks, I'm not sure what needs to be changed but wanted to get it started. We're planning a 5.0 release, so thought we could get this in. Feel free to commit or start a new PR if necessary. |
Closing in favor of #7795 |