Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dafny 3.4.2 Requires C# 8 #1873

Closed
texastony opened this issue Feb 28, 2022 · 1 comment · Fixed by #1877
Closed

Dafny 3.4.2 Requires C# 8 #1873

texastony opened this issue Feb 28, 2022 · 1 comment · Fixed by #1877
Assignees
@MikaelMayer
Labels
kind: enhancement Enhancements, feature requests, etc. These are NOT bugs, but ways we can improve Dafny lang: c# Dafny's C# transpiler and its runtime part: runtime Happens in Dafny's runtime (Add a `lang` tag if relevant)

Comments

@texastony
Copy link

While testing Dafny 3.4.2 on our library, which targets C#, we encountered the following error when testing in C#:

src/redacted/redacted/redacted/redacted/Source/obj/Debug/netstandard2.0/GeneratedFromDafny.cs(11926,20): error CS8370: Feature 'recursive patterns' is not available in C# 7.3. Please use language version 8.0 or greater.

There is no call out in the release notes for 3.4.2 that C#8 will now be required.

Our library works fine on Dafny 3.4.1.

Thank you!
@fabiomadge
Copy link
Collaborator

The change was part of #1780 and there is no real need for it, so we can just replace the offending line with something backwards compatible.

@MikaelMayer MikaelMayer self-assigned this Mar 1, 2022
@MikaelMayer MikaelMayer added the lang: c# Dafny's C# transpiler and its runtime label Mar 1, 2022
MikaelMayer added a commit that referenced this issue Mar 1, 2022
@MikaelMayer
fix #1873
b95ba1d 
Enforces the runtime csharp version to be as low as possible.
@MikaelMayer MikaelMayer mentioned this issue Mar 1, 2022
Merged
@MikaelMayer MikaelMayer added part: runtime Happens in Dafny's runtime (Add a `lang` tag if relevant) kind: enhancement Enhancements, feature requests, etc. These are NOT bugs, but ways we can improve Dafny labels Mar 1, 2022
MikaelMayer added a commit that referenced this issue Mar 1, 2022
@MikaelMayer
Fix: Lower C# runtime version to 7.3 (#1877)
76c8d59 
* fix #1873
Enforces the runtime csharp version to be 7.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikaelMayer MikaelMayer

Labels
kind: enhancement Enhancements, feature requests, etc. These are NOT bugs, but ways we can improve Dafny lang: c# Dafny's C# transpiler and its runtime part: runtime Happens in Dafny's runtime (Add a `lang` tag if relevant)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Lower C# runtime version to 7.3 dafny-lang/dafny
3 participants
@fabiomadge @MikaelMayer @texastony