Fix: Lower C# runtime version to 7.3 #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomadge
previously approved these changes
Mar 1, 2022
| @@ -9,6 +9,7 @@ | |||
| <PackageVersion>1.1.0</PackageVersion> | |||
| <TargetFramework>net6.0</TargetFramework> | |||
| <OutputPath>..\..\Binaries\</OutputPath> | |||
| <LangVersion>7.1</LangVersion> | |||
There was a problem hiding this comment.
The default for even the ancient dotnet versions is 7.3. Should we maybe target that?
|
Thanks for taking care of that. I would have gotten to it... eventually |
Co-authored-by: Fabio Madge <[email protected]>
MikaelMayer
commented
Mar 1, 2022
MikaelMayer
commented
Mar 1, 2022
MikaelMayer
changed the title
fabiomadge
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces the runtime c# version to be 7.3 for now.
Fixes #1873
I added an explicit versioning for the c# language in the DafnyRuntime.csproj, which detected advanced features and led me to revert those to usual features. That way, we can stay backward compatible longer.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.