Redirect after sign-in breaks with query parameters

[CobusKruger]

Describe the bug
I previously had custom code to pick up the redirect entry from storage and navigate to it. When I upgraded to 11.6.4, I had to take it out, because of the navigate() call on this line:

angular-auth-oidc-client/projects/angular-auth-oidc-client/src/lib/check-auth.service.ts

Line 79 in 630f4e7

this.router.navigate([savedRouteForRedirect]);

// in check-auth.service.ts, checkAuth function:
      tap(() => {
        const savedRouteForRedirect = this.autoLoginService.getStoredRedirectRoute();
        if (savedRouteForRedirect) {
          this.autoLoginService.deleteStoredRedirectRoute(); // This removes the entry
          this.router.navigate([savedRouteForRedirect]);         // This navigates and causes the error
        }
      }),

My own navigation failed (as expected) because the redirect entry no longer exists by the time my code executed.

The new problem is that if the redirect entry contains any path with query parameters, navigation will fail. That's because navigate() doesn't support query parameters as part of the commands array. Suppose I have a URL like /?p=1, I will receive the following error:

ERROR Error: Uncaught (in promise): Error: Cannot match any routes. URL Segment: 'p%3D1'

Changing that line to the following should work:

          this.router.navigateByUrl(savedRouteForRedirect); // Supports query parameters

To Reproduce
Steps to reproduce the behavior:

1. Have an app with authentication enabled.
2. Paste a URL without query parameters into the browser address bar and press Enter. This goes through the login flow, then routes to the supplied path. Expected
3. Paste a URL with query parameters into the browser address bar and press Enter. This goes through the login flow, then throws an error to say Cannot match any routes. Not expected

Expected behavior
Navigate to the redirect URL, whether it has query parameters or not.

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Chrom
• Version: 89.0.4389.114

I'll be happy to make the change.

[FabianGosebrink]

Hey, thanks for this. Did you try if the error is gone when you work with the QueryParamsHandling?

[CobusKruger]

I don't know what that is, but I'll investigate it.

…

On Mon, 12 Apr 2021, 19:43 Fabian Gosebrink, ***@***.***> wrote: Hey, thanks for this. Did you try if the error is gone when you work with the QueryParamsHandling <https://angular.io/api/router/QueryParamsHandling>? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1042 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACTDRUTRV4GJJDUVJXWIJ2TTIMWLXANCNFSM42ZUOVXQ> .

[FabianGosebrink]

You can configure how Angular handles the queryParams. So maybe this solves the issue. You can test it and please let us know. Thanks!

[CobusKruger]

@FabianGosebrink I looked into QueryParamsHandling, and I can't see how that helps in my case. Setting it to merge or preserve gets the router to pass them on, but we're going through Azure AD authentication. More than that, it's passed as a parameter to navigate(), and I don't see a way to set it globally.

[FabianGosebrink]

Could be related to #1028 and fixed by #1051 which is released. Please check and close if the issue is solved.