Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use navigateByUrl to fix url params encoding #1051

Merged
merged 1 commit into from
Apr 17, 2021
Merged

fix: use navigateByUrl to fix url params encoding #1051

merged 1 commit into from
Apr 17, 2021

Conversation

TomaszKasowicz
Copy link
Contributor

Change router.navigate() calls to router.navigateByUrl()

Fixes #1028

@damienbod
Copy link
Owner

@TomaszKasowicz thank you! LGTM

@FabianGosebrink good for you as well?

@FabianGosebrink
Copy link
Collaborator

Yeah is fine for me. We can merge imho. @TomaszKasowicz thank you very much!

@damienbod damienbod merged commit bc93390 into damienbod:main Apr 17, 2021
@FabianGosebrink FabianGosebrink mentioned this pull request Apr 22, 2021
Closed
@timdeschryver timdeschryver mentioned this pull request Mar 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular Router navigations should be (probably) triggered with navigateByUrl() function
3 participants
@TomaszKasowicz @damienbod @FabianGosebrink