ux: Local Search Redesign #2211
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch redesigns the pull down search view by improving the search bar. In addition minor ux/ui improvements are done such as: - hiding the timeline when the user is searching - hiding the custom picker when the user is searching - text suggesting the user try searching for keywords - dismiss the keyboard on scroll Testing —— iPhone 15 Pro Max (17.3.1) Dark Mode: https://v.nostr.build/WGGzk.mp4 iPhone SE (3rd generation) (16.4) Light Mode: https://v.nostr.build/Q77Vv.mp4 —— Fixes: damus-io#2074 Closes: damus-io#2046 Changelog-Fixed: search results remaining after empty search Changelog-Changed: local search ux/ui Signed-off-by: ericholguin <[email protected]> PATCH CHANGELOG: V1 -> V2: addressed review comments regarding state variables in ContentView and stuttering search bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opened this to keep track of @ericholguin 's search ux changes
This patch redesigns the pull down search view by improving the search bar. In addition minor ux/ui improvements are done such as:
Testing
——
iPhone 15 Pro Max (17.3.1) Dark Mode:
https://v.nostr.build/WGGzk.mp4
iPhone SE (3rd generation) (16.4) Light Mode:
https://v.nostr.build/Q77Vv.mp4
——
Fixes: #2074
Closes: #2046
Changelog-Fixed: search results remaining after empty search
Changelog-Changed: local search ux/ui
Signed-off-by: ericholguin [email protected]
PATCH CHANGELOG:
V1 -> V2: addressed review comments regarding state variables in ContentView and stuttering search bar