Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux: Local Search Redesign #2211

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Mar 26, 2024

  1. ux: Local Search Redesign

    This patch redesigns the pull down search view by improving the search bar.
    In addition minor ux/ui improvements are done such as:
    - hiding the timeline when the user is searching
    - hiding the custom picker when the user is searching
    - text suggesting the user try searching for keywords
    - dismiss the keyboard on scroll
    
    Testing
    ——
    iPhone 15 Pro Max (17.3.1) Dark Mode:
    https://v.nostr.build/WGGzk.mp4
    
    iPhone SE (3rd generation) (16.4) Light Mode:
    https://v.nostr.build/Q77Vv.mp4
    
    ——
    
    Fixes: damus-io#2074
    Closes: damus-io#2046
    Changelog-Fixed: search results remaining after empty search
    Changelog-Changed: local search ux/ui
    
    Signed-off-by: ericholguin <[email protected]>
    
    PATCH CHANGELOG:
    V1 -> V2: addressed review comments regarding state variables in ContentView and stuttering search bar
    ericholguin committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    57782f3 View commit details
    Browse the repository at this point in the history