Builder State to transfer parameters #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argument ot the renderer. But this is not going to work...
|
Feel free to suggest a better class / variable name for the state. |
|
Thanks a lot mate. Looks good. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The item, that the *Renderers take way to much arguments in #196 is valid. To solve this I extracted the builder state in its own class, which is then passed to the renderer.
This allows to get more state / parameters into the builder without extending the constructors all the time. That those state classes are public is a pity, but we don't have C++ friend classes at hand here...
This also adds the TestcaseRunner to the regression tests, just as a "smoke" test.