Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder State to transfer parameters #199

Merged
merged 7 commits into from
Apr 9, 2018
Merged

Builder State to transfer parameters #199

merged 7 commits into from
Apr 9, 2018

Commits on Apr 8, 2018

  1. This interface is rather pointless.

    @rototor
    rototor committed Apr 8, 2018
    Configuration menu
    Copy the full SHA
    c036b9e View commit details
    Browse the repository at this point in the history

  2. Use the testcase runner also as an regression test.

    @rototor
    rototor committed Apr 8, 2018
    Configuration menu
    Copy the full SHA
    d708010 View commit details
    Browse the repository at this point in the history

  3. Implemented a "sealed" mode for the builder to be able to pass it as 

    argument ot the renderer. But this is not going to work...
    @rototor
    rototor committed Apr 8, 2018
    Configuration menu
    Copy the full SHA
    a8f2a9c View commit details
    Browse the repository at this point in the history

  4. Extract the state of the builder in its own class with all public fields

    @rototor
    rototor committed Apr 8, 2018
    Configuration menu
    Copy the full SHA
    0d16490 View commit details
    Browse the repository at this point in the history

  5. Make the PdfBoxRenderer use the builder state as it's parameter.

    @rototor
    rototor committed Apr 8, 2018
    Configuration menu
    Copy the full SHA
    491a09f View commit details
    Browse the repository at this point in the history

  6. Also use the state for the Java2D renderer.

    @rototor
    rototor committed Apr 8, 2018
    Configuration menu
    Copy the full SHA
    839dbd6 View commit details
    Browse the repository at this point in the history

  7. Make the constructor of the builder states package only.

    @rototor
    rototor committed Apr 8, 2018
    Configuration menu
    Copy the full SHA
    b58b4c3 View commit details
    Browse the repository at this point in the history