Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questions #100

Closed
ab-pm opened this issue Sep 12, 2019 · 2 comments
Closed

Questions #100

ab-pm opened this issue Sep 12, 2019 · 2 comments

Comments

@ab-pm
Copy link

ab-pm commented Sep 12, 2019

Hi! Before deciding to use this library, which seems well devised, I've got two questions:

  • How can I seed the data generators, how can I set their locale options?
  • Why does build return a promise? Nothing in this library appears to be asynchronous.
@danibram
Copy link
Owner

Hi!

  1. This library, is a helper (wrapper) for chance, faker, randexp, casual so for the locale options check this libraries. If you read the documentation you can use as this:

{ faker: 'address.streetAddress', locale: 'zh_CN' } // Got 711 蔡 街

  1. I made like this, because I didnt want to change too much things if I want to include an asyncronous library in the future, and because I wanted.

You are free to contribute for the module if you want or you can make a fork and change if you want.

10xjs added a commit to 10xjs/mocker-data-generator that referenced this issue Sep 3, 2020
@10xjs
feat: add buildSync method to Mocker class
e64c7a7 
Add a new `buildSync` method alongside the existing `build` method to allow the generator to be used where synchronous flow is required.

This is a simple non-breaking surface-level change. The library does not currently include any internal async logic. The async behavior of the `build` method is designed to avoid an unwanted breaking interface change in the future if async logic is added (discussed [here](danibram#100)). If async generators are added in the future, I suggest that they be excluded from the set of generators available for use when calling `buildSync` - this could be achieved cleanly in typescript by giving the `Mocker` class a generic `Schema` type that is referenced in conditional types on the `build` and `buildSync` methods. This would also require adding strict type inference to the schema interface, but doing so could have the added benefit of returning non-opaque typed data.
10xjs added a commit to 10xjs/mocker-data-generator that referenced this issue Sep 3, 2020
@10xjs
feat: add buildSync method to Mocker class
967fdbc 
Add a new `buildSync` method alongside the existing `build` method to allow the generator to be used where synchronous flow is required.

This is a simple non-breaking surface-level change. The library does not currently include any internal async logic. The async behavior of the `build` method is designed to avoid an unwanted breaking interface change in the future if async logic is added (discussed [here](danibram#100)). If async generators are added in the future, I suggest that they be excluded from the set of generators available for use when calling `buildSync` - this could be achieved cleanly in typescript by giving the `Mocker` class a generic `Schema` type that is referenced in conditional types on the `build` and `buildSync` methods. This would also require adding strict type inference to the schema interface, but doing so could have the added benefit of returning non-opaque typed data.
10xjs added a commit to 10xjs/mocker-data-generator that referenced this issue Sep 3, 2020
@10xjs
feat: add buildSync method to Mocker class
772b20d 
Add a new `buildSync` method alongside the existing `build` method to allow the generator to be used where synchronous flow is required.

This is a simple non-breaking surface-level change. The library does not currently include any internal async logic. The async behavior of the `build` method is designed to avoid an unwanted breaking interface change in the future if async logic is added (discussed [here](danibram#100)). If async generators are added in the future, I suggest that they be excluded from the set of generators available for use when calling `buildSync` - this could be achieved cleanly in typescript by giving the `Mocker` class a generic `Schema` type that is referenced in conditional types on the `build` and `buildSync` methods. This would also require adding strict type inference to the schema interface, but doing so could have the added benefit of returning non-opaque typed data.
@10xjs 10xjs mentioned this issue Sep 3, 2020
Merged
@danibram
Copy link
Owner

danibram commented Sep 4, 2020

@ab-pm in v2.9.0 @10xjs added the method to build syncronously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danibram @ab-pm