Add synchronous build method #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new `buildSync` method alongside the existing `build` method to allow the generator to be used where synchronous flow is required. This is a simple non-breaking surface-level change. The library does not currently include any internal async logic. The async behavior of the `build` method is designed to avoid an unwanted breaking interface change in the future if async logic is added (discussed [here](danibram#100)). If async generators are added in the future, I suggest that they be excluded from the set of generators available for use when calling `buildSync` - this could be achieved cleanly in typescript by giving the `Mocker` class a generic `Schema` type that is referenced in conditional types on the `build` and `buildSync` methods. This would also require adding strict type inference to the schema interface, but doing so could have the added benefit of returning non-opaque typed data.
|
this node 14.x bug appears to be causing the CI execution to fail |
10xjs
force-pushed
the
master
branch
4 times, most recently
from
24bf8c6
to
772b20d
Compare
|
CI will continue to fail pending the fix in #112 |
|
Nice work @10xjs! Thanks! |
|
Live in v2.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
buildSyncmethod alongside the existingbuildmethod to allow the generator to be used where synchronous flow is required.This is a simple non-breaking surface-level change. The library does not currently include any internal async logic. The async behavior of the
buildmethod is designed to avoid an unwanted breaking interface change in the future if async logic is added (discussed here). If async generators are added in the future, I suggest that they be excluded from the set of generators available for use when callingbuildSync- this could be achieved cleanly in typescript by giving theMockerclass a genericSchematype that is referenced in conditional types on thebuildandbuildSyncmethods. This would also require adding strict type inference to the schema interface, but doing so could have the added benefit of returning non-opaque typed data.