Make PAS ignore pedal rotation during Walk Assist

[majonessyltetoy]

When engaging Walk Assist my pedals rotate with the chainring (I know I should clean and lube the motor).
After releasing Walk Assist, since the pedals have been rotating PAS kicks in and send the bike (which I'm walking) into full throttle of whichever Assist Level it is in.

User solution: Go into Assist Level 0 before using Walk Assist or have a well maintained motor which does not rotate the pedals when the chainring rotate.

Developer solution: Make PAS ignore pedal rotation during Walk Assist and possibly have a timeout after Walk Assist like the original firmware.

[dav0000000]

Pas would be ignored during PUSH as that function is not called. I'd guess it is likely something to do with ramp down or another function adding power where it shouldn't the moment PUSH is released.

[majonessyltetoy]

Yes, but as soon as the user let go of the Walk Assist, then PAS reads the cadence pulse counter, which has been building up.

Would something like this work?
c96bd2e

I don't have a build env to test it out.

[dav0000000]

Not what you want to hear but the best solution for you it to buy and install a new pawl clutch (if that is the problem) and of course to setup a build environment. Your approach looks ok to me, you might want to stop the timer to update the value as it is a uint16_t.

void pas_zero_pulse_counter()
{
ET0 = 0; // disable timer0 interrupts
pas_pulse_counter = 0;
ET0 = 1;
}

[aalm]

I don't have a build env to test it out.

Have you managed to build it yet?
Was relatively easy to get the makefile working on linux(rpi4) for build env.

[danielnilsson9]

I guess this could be a quite common issue as I have this problem on my 6 year old bbshd too. Will try to add a fix in next version.

[danielnilsson9]

Implemented a 1 second timeout when releasing push walk, let me know how it works if anyone decides to test.

[majonessyltetoy]

Implemented a 1 second timeout when releasing push walk, let me know how it works if anyone decides to test.

Thank you. That fixed the issue :)