Skip to content

Commit

Permalink
LSP: Fix codeAction/resolve server capability check (helix-editor#8421)
Browse files Browse the repository at this point in the history
Previously we accidentally checked the server's _completion_ resolve
capability rather than the code action resolve capability.
  • Loading branch information
the-mikedavis authored and danillos committed Nov 21, 2023
1 parent 612e0eb commit bcaeb08
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions helix-lsp/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -971,12 +971,12 @@ impl Client {
) -> Option<impl Future<Output = Result<Value>>> {
let capabilities = self.capabilities.get().unwrap();

// Return early if the server does not support resolving code action.
match capabilities.completion_provider {
Some(lsp::CompletionOptions {
// Return early if the server does not support resolving code actions.
match capabilities.code_action_provider {
Some(lsp::CodeActionProviderCapability::Options(lsp::CodeActionOptions {
resolve_provider: Some(true),
..
}) => (),
})) => (),
_ => return None,
}

Expand Down

0 comments on commit bcaeb08

Please sign in to comment.