LSP: Fix codeAction/resolve server capability check #8421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we accidentally checked the server's _completion_ resolve capability rather than the code action resolve capability.
the-mikedavis
added
C-bug
danillos
pushed a commit
to danillos/helix
that referenced
this pull request
Nov 21, 2023
Previously we accidentally checked the server's _completion_ resolve capability rather than the code action resolve capability.
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
Previously we accidentally checked the server's _completion_ resolve capability rather than the code action resolve capability.
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Previously we accidentally checked the server's _completion_ resolve capability rather than the code action resolve capability.
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Previously we accidentally checked the server's _completion_ resolve capability rather than the code action resolve capability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we accidentally checked the server's completion resolve capability rather than the code action resolve capability. It looks like this was an oversight introduced in #7677.
Fixes #8413
Fixes astral-sh/ruff-lsp#249