Epoch single pass #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
force-pushed
the
epoch-single-pass
branch
4 times, most recently
from
51fcc68
to
23e10c6
Compare
dapplion
commented
Feb 7, 2024
| .epoch_cache() | ||
| .check_validity::<E>(current_epoch, epoch_cache_decision_block_root) | ||
| .is_ok() | ||
| } |
There was a problem hiding this comment.
Should this include the tree_hash_cache?
dapplion
commented
Feb 7, 2024
dapplion
commented
Feb 7, 2024
| @@ -4,6 +4,7 @@ use std::collections::HashMap; | |||
|
|
|||
| type ValidatorIndex = usize; | |||
|
|
|||
| #[allow(clippy::len_without_is_empty)] | |||
There was a problem hiding this comment.
Why is clippy complaining in this PR and not in unstable?
dapplion
force-pushed
the
epoch-single-pass
branch
2 times, most recently
from
a63e4b6
to
73bd7a2
Compare
Co-authored-by: Michael Sproul <[email protected]>
* Delete unused epoch processing code * Compare total deltas * Remove unnecessary apply_pending * cargo fmt * Remove newline
dapplion
force-pushed
the
epoch-single-pass
branch
from
73bd7a2
to
94bb079
Compare
This was referenced Feb 9, 2024
* spec compliant process_sync_aggregate * Update consensus/state_processing/src/per_block_processing/altair/sync_committee.rs Co-authored-by: Michael Sproul <[email protected]> --------- Co-authored-by: Michael Sproul <[email protected]>
dapplion
force-pushed
the
epoch-single-pass
branch
from
2b10361
to
e5341d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick epoch single pass feature from sigp#3206. For more details on the feature:
TODOs
lighthouse/consensus/state_processing/src/common/update_progressive_balances_cache.rs
Line 29 in 23e10c6
lighthouse/consensus/state_processing/src/per_epoch_processing/altair/participation_cache.rs
Lines 475 to 476 in 23e10c6
lighthouse/consensus/state_processing/src/per_block_processing/altair/sync_committee.rs
Line 55 in 23e10c6
lighthouse/consensus/state_processing/src/per_epoch_processing/epoch_processing_summary.rs
Line 146 in 23e10c6
lighthouse/consensus/types/src/chain_spec.rs
Line 323 in 23e10c6