This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mannprerak2 any types you think we should add to this PR? |
I think this would suffice. |
mkustermann
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with comments. Though our offline discussion decided we'll put them into dart:ffi
. I suppose you're intending to do both?
Yes both, so that we can use Let's land the SDK one first, we can do easier C++ tests there. And then copy the definitions over to this PR. |
dcharkes
added a commit
that referenced
this pull request
May 13, 2022
dcharkes
added a commit
to dart-lang/native
that referenced
this pull request
Jan 16, 2024
dcharkes
added a commit
to dart-lang/native
that referenced
this pull request
Jan 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy of
c_type.dart
from https://dart-review.googlesource.com/c/sdk/+/228541 which will only arrive indart:ffi
in 2.17 so that we can use this in Dart 2.16.Adds support for the common C types:
char
unsigned char
signed char
short
unsigned short
int
unsigned int
long
unsigned long
long long
unsigned long long
uintptr_t
size_t
wchar_t
Requires Dart 2.16.
Unblocks: